Open
Conversation
|
Could a maintainer please clarify on why this PR is not being reviewed and/or merged? It's a small change which could help a lot of people out. |
Contributor
|
@bartlomieju With the Docker Hub pull rate limit getting stricter starting in April, I think this feature makes sense. |
SPPRAGUE
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds pushing to ghcr.io in addition to docker hub.
I'm interested in using deno at my company hosted on AWS ECS and built using codebuild. I would like to use the images defined here, however because they are only available on docker hub, and our company does not use a business docker hub license, we cannot use these images.
There are a few issues also showing interest in this use case, see: #164, #321
There was also a recent PR adding docker hub descriptions, it appears GHCR expects image labels for defining source, description, and licenses. I would be happy to add those to the dockerfiles if that would be desirable.
Thanks